Closed ericpyle closed 5 years ago
This is due to your material-ui version, which is too high.
@gabrielliwerant how can that be? I'm just running the tests from your repo (not mine).
Your package json references: "@material-ui/core": "^3.2.0",
I don't know how this issue occurred for you, as I do not have this problem, and the repo is passing the coveralls checks via the github integration.
Check your package-lock.json
for "@material-ui/core"
and see what version it has. You might need to clear your npm cache and reinstall all the packages from the repo.
Also, which branch are you testing?
@gabrielliwerant master
, I did find "@material-ui/core": { "version": "3.5.1",
in my package-lock.json
.
And thanks for reminding me about the github showing status of passed tests.
Hm, that version should work. I know that material-ui v3.6.1 introduces a breaking change with respect to mui-datatables tests that produces the exact errors and outputs you received, so I suspect you have a higher version cached or installed.
Also be mindful that this repo does not use yarn. I notice a lot of people using yarn when working specifically with this library. It's fine in your own project, but using yarn while testing and working directly with this library may create unexpected issues. I would stick with npm for those cases.
All tests pass now. Deleted node_modules and yarn.lock and did npm install. Thanks for your help!
On Fri, May 31, 2019 at 2:51 PM Gabriel Liwerant notifications@github.com wrote:
Hm, that version should work. I know that material-ui v3.6.1 introduces a breaking change with respect to mui-datatables tests that produces the exact errors and outputs you received, so I suspect you have a higher version cached or installed.
Also be mindful that this repo does not use yarn. I notice a lot of people using yarn when working specifically with this library. It's fine in your own project, but using yarn while testing and working directly with this library may create unexpected issues. I would stick with npm for those cases.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/gregnb/mui-datatables/issues/656?email_source=notifications&email_token=AAISZPKNIYUI3JTAHD7H5VTPYF6TDA5CNFSM4HR4DC32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWWG2YQ#issuecomment-497839458, or mute the thread https://github.com/notifications/unsubscribe-auth/AAISZPLTFPSNT2J5EKIHLXTPYF6TDANCNFSM4HR4DC3Q .
-- Eric Pyle Dallas, TX SIL - Language Software Developer Skype: eric.d.pyle
when running
yarn tests
off latest master 2.3.0 mui-datatables, I'm getting 18 failed tests related due toReferenceError: HTMLInputElement is not defined
Expected Behavior
All tests pass
Current Behavior
Steps to Reproduce (for bugs)
yarn test
Your Environment