search

gregwebs / haskell-heroku

Haskell helpers for deploying to Heroku
BSD 3-Clause "New" or "Revised" License
18 stars 6 forks source link

Why parseDatabaseUrl returns "dynamic type" [(Text, Text)] #8

Open phadej opened 10 years ago

phadej commented 10 years ago

Could we merge https://github.com/futurice/pulmurice-heroku/blob/master/src/Pulmurice/Heroku/PostgreSQL.hs approach here?

gregwebs commented 10 years ago

I would like to have a base package with very few dependencies and build on top of that,

phadej commented 10 years ago

You could have a very same data type as ConnectInfo in the heroku?

gregwebs commented 10 years ago

My concern is just that the code add the postgresql-simple dependency. I would like for there to be a heroku package that has minimal dependencies, and will gladly accept any pull requests that maintains that. It would be good to have separate heroku-postgresql packages that require a postgresql dependency.

phadej commented 9 years ago

I created another package: http://hackage.haskell.org/package/postgresql-simple-url let people decide which to use.

gregwebs commented 9 years ago

Great! Can you add a link to it from documentation in this project?

phadej commented 9 years ago

you mean amend the README ?

gregwebs commented 9 years ago

Sure

phadej commented 9 years ago

Ok, will do shortly. Good idea to cross link these. I'll reopen this issue to not to forget