search

gregzaal / Gaffer

A light-manager add-on for Blender
387 stars 30 forks source link

Proper Implementation of Loading Custom icons #49

Closed blenderskool closed 7 years ago

blenderskool commented 7 years ago

Since the add-on has started using many custom icons..... it adds up to memory usage, and therefore I was conducting a small test of activating-deactivating add-on too many times, fast and continuous.... and Blender crashed. This is because custom icons are not properly loaded. I checked retopoflow add-on which also uses custom icons, and this problem does not occur there.

Really minor thing just thought to inform you 😃

gregzaal commented 7 years ago

I couldn't reproduce this - how do you know it's caused by custom icons?

blenderskool commented 7 years ago

I found it out when I was using custom icons in my add-on. Here is a gif that can show what I mean http://imgur.com/a/y9jbl

gregzaal commented 7 years ago

Are you using the latest blender master? What OS?

blenderskool commented 7 years ago

Yes, I used the latest add-on, using Blender 2.78a on Windows 10

gregzaal commented 7 years ago

Could you try with a newer build of blender from builder.blender.org ? I seem to remember something about memory leaking icons, might have been a bug that got fixed.

blenderskool commented 7 years ago

I tried the latest build, works fine 👍

gregzaal commented 7 years ago

Excellent!