Support for Symfony 5 - Githubissues

gremo / ZurbInkBundle

Creating email templates is hard. This Symfony Bundle provides help.

MIT License

24 stars 12 forks source link

Support for Symfony 5 #7

Open signor-pedro opened 4 years ago

signor-pedro commented 4 years ago

Hi, is this package still maintained?

I would like to ask if we can expect SF5 support anytime soon, or are you welcoming pull requests?

Thanks

gremo commented 4 years ago

Hi, thanks for asking!

I use this package on daily basis, at work, so yes it's still maintained. However we are using Symfony 4 ATM and I'm not switching to Symfony 5 anytime soon.

Feel free to create a PR!

signor-pedro commented 4 years ago

I have a working fork, so far it looks good but I have to make sure everything is OK.

I will keep you posted.

dbollaer commented 3 years ago

@signor-pedro I would also like to upgrade this bundle to symfony 5. Would you mind making a PR? thank you in advance.

grifx commented 2 years ago

I'm planning to upgrade to php8.1 & Symfony 5

We could also change the php constraint to:

"php": ">=5.6.0",

All the dependencies support 8.x but unsure if it runs smoothly.

grifx commented 2 years ago

@signor-pedro

I don't think you can support all versions of twig.

Did you forget some use statements?

hracik commented 2 years ago

I continued on @signor-pedro work and created another pull request, removing the old Twig classes/dependency as well as allowing PHP 8.