greneholt / youtube5

Safari extension that converts YouTube videos on any site into HTML5 video tags
http://www.verticalforest.com
Other
111 stars 17 forks source link

Start time feature #19

Closed dlh closed 12 years ago

dlh commented 12 years ago

I added support for YouTube's start/t/time URL parameters, and the #t= hash syntax.

riddle commented 12 years ago

I’d love to see it working. Greneholt, can you please pull the code? It’s like linking to #hash for text content, very useful. I still have to open Chrome to test my #t= links when I share parts of YouTube videos with my friends.

vpieter commented 12 years ago

I've been watching this thread for a while now, and I'll join in saying that to me it's the biggest annoyance with this otherwise excellent extension. When I click a link to a referencing video I often have to go looking for the right minute/second part to see what is being referred to.

greneholt commented 12 years ago

I apologize that I did not pull this a long time ago, but in the meantime YouTube5 has been majorly refactored and this change is out of sync. This is also the wrong place for this change to be made. It should be done in the player, not the loading code, so that clicking on links on a video page will jump to that point without reloading everything. I also don't like adding features to YouTube5 that only work on one site. There are ways this could be implemented that would support both YouTube and Vimeo.

For instance:

If someone would like to make these changes and submit a new pull request, I'd be glad to review and merge it. But at the moment I don't have time to make these changes myself.

greneholt commented 11 years ago

Just wanted to let everyone know that YouTube5 v2.5.1 has full support for start times through link hashes, embeds, and even timecode links in comments.

greneholt commented 11 years ago

Thanks to dlh for some of the code included in the new version.

vpieter commented 11 years ago

Thanks so much to both of your for your time.