search

greneholt / youtube5

Safari extension that converts YouTube videos on any site into HTML5 video tags
http://www.verticalforest.com
Other
111 stars 17 forks source link

Fix YouTube for users without Flash installed #33

Closed dlh closed 11 years ago

dlh commented 11 years ago

This change breaks the "Use original player" action, so I don't really expect it to be merged.

I'll try to take a look at fixing that, but feel free to tackle it yourself.

Issue #32 is related.

dlh commented 11 years ago

Actually, this still has issues: the youtube HTML5 player for some videos will load (but it is in the hidden div), and it autoplays.

dlh commented 11 years ago

I've blocked the loading of the (autoplaying) html5 player. However, the “Use original player” action is still broken.

Still, this solution is rather hacky…

ggustafsson commented 11 years ago

I tried it but it doesn't work. I just double-clicked on the safariextz file. Need a fix so bad :'(

ylor commented 11 years ago

If you turn off auto-play YouTube videos in the extension settings it cleared up the issue for me.

greneholt commented 11 years ago

Thanks for this code, but I have chosen to fix the issue in a slightly more hackish, but more reliable way. Sorry its taken so long.