When a source is from ASCO, the journal is being resolved incorrectly

griffithlab / civic-client

Web client for CIViC: Clinical Interpretations of Variants in Cancer

MIT License

50 stars 28 forks source link

When a source is from ASCO, the journal is being resolved incorrectly #1612

Closed malachig closed 3 years ago

malachig commented 3 years ago

All ASCO sources should list: Journal of Clinical Oncology as their Journal. Instead the ASCO ID is being used to pull the journal for the PubMed entry with that ID, leading to seemingly random journal assignments.

e.g. https://civicdb.org/sources/2862/summary

Resolves to a Journal: Texas Medicine. Because the ASCO ID: https://meetinglibrary.asco.org/record/159508/abstract is pulling the journal from this unrelated paper in pubmed here: https://pubmed.ncbi.nlm.nih.gov/159508/

susannasiebert commented 3 years ago

I think this is leftover bad data from before we deployed this PR: https://github.com/griffithlab/civic-server/pull/588. The ASCO scraper doesn't set a full_journal_title so that field was never fixed. We will need to update the ASCO scraper to set this field correctly and manually update the ASCO entries in the database to the correct journal title.