grishka / Houseclub

A barebones unofficial Android app for Clubhouse
The Unlicense
2.36k stars 399 forks source link

Abandoned repository #302

Open vgpastor opened 3 years ago

vgpastor commented 3 years ago

Hi @grishka

If you can mantain the repo can you open to other devs to can help in the repository? The repository of are multiple commits ahead of you https://github.com/omarss/Houseclub. I push PR to this reposirty because this are not updated.

If i can help you please contact me.

Regards!

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Mayrakis commented 3 years ago

I saw it have invite feature, it work?

grishka commented 3 years ago

What exactly do you mean by "maintaining", anyway? I certainly could improve the bot that auto-closes issues because people just never ever fill the template.

Just to reiterate, for everyone reading this: if you aren't a developer, you aren't supposed to have a GitHub account.

vgpastor commented 3 years ago

Sorry i can't understand you :( I don't said any about the bot in issues

I only try to offer my hands to collaborate to have the repo updated

grishka commented 3 years ago

To have it updated with what? It's fine as it is.

grishka commented 3 years ago

The whole clubhouse hype has subsided anyway. And an official app is on the way, so there's not much sense to continue with this project.

vgpastor commented 3 years ago

In your repo has 20 PR with new features and bug fixes, that can make better the applicattion.

I understand you, but i think that the official app need almost 3 months, so if you like please close PR and issues and redirect users to my repo for example, because i try to learn more about the application and try to upgrade this.

My repo are https://github.com/vgpastor/ClubHouseUnOfficial and try to upload to playstore, mention you and your repo of course.

grishka commented 3 years ago

I reviewed all those PRs and there were many things I didn't like about them, which is why I didn't merge them.

vgpastor commented 3 years ago

But the open source consist in speak with other devs and accept modifications and collaborations, if don't like the code of others devs speak with them and propose an alternative, so you can the repo better.

grishka commented 3 years ago

There's such a thing as feature completeness. It's when you say your product is done. When there's nothing to be added to it. When you only fix bugs but don't add any new features. It's a misconception that if something isn't being constantly updated, it's dead.

vgpastor commented 3 years ago

But the bugs make the users can't test better the applicattion and send new feedback. In the actually repos that are not updated when users add code it's the same that don't have anything. If i refactor anything for exampe and you don't merge in a few days it's probably that others devs write anothers lines that in the future when you decide merge them exists conflict and make unsastainable.

I think that it's better add PR every time that you can, for this reason i offer you collaborate to make updated the repo

itszakjo commented 3 years ago

@vgpastor There is lots of spaghetti code and messy structures in the PRS my man. If he merges those prs it will turn into a mess , I have forked this repo and I am doing updates from time to time just for fun following the same code structure he built at first. But please don't take this too serious as it is not an official app , it is not supposed to be acting as an official app at all. Just the basic stuff for fun and for educational purposes as well.

If you REALLY want new updates try this release

https://github.com/itszakjo/Houseclub-updated/releases/tag/1.1.1

Regardless that the official app is coming soon please don't do any pull requests or report issues to it or request new features because I will only work on it if I have free time. Thank you.

vgpastor commented 3 years ago

@itszakjo Your repository its only two commits ahead @grishka in https://github.com/vgpastor/ClubHouseUnOfficial you can see a version that i send to google play and are waiting approval, while you can download https://github.com/vgpastor/ClubHouseUnOfficial/releases/tag/2.0.1

I'm open to make you a developer in the repository if you like and centralize the updates

Edit: Master of the reposiroty that send you it's This branch is 88 commits ahead of grishka:master.

itszakjo commented 3 years ago

Lol this repo u sent was actually copied from - houseclub-updated - my repo in the first place

grishka commented 3 years ago

a version that i send to google play and are waiting approval

Publishing unofficial apps based on a reverse engineered API on Google Play is a very terrible idea. I hope you aren't doing that from an account that is valuable to you.

itszakjo commented 3 years ago

Someone uploaded the app already on google play and Google play took it down already.

grishka commented 3 years ago

Yeah, told you so

vgpastor commented 3 years ago

@itszakjo i see the forks and continue , the most updated repo was https://github.com/omarss/Houseclub. I'm documented the base of codes

houska85 commented 3 years ago

I don't think it's worth further. Here I found a complete application based on this project. https://play.google.com/store/apps/details?id=app.clubhouse.br

mkljczk commented 3 years ago

@houska85 well, looking at the screenshots, it lacks many features included by forks, doesn't include the warning about possibility of being banned and has tons of ads.

houska85 commented 3 years ago

I decompiled the application to be sure. Currently, almost everything is there. Ads are being implemented but are still inactive.