search

grizzl / fiplr

[DEPRECATED] An Emacs Fuzzy Find in Project Package
187 stars 14 forks source link

Add commands to open in other window or frame #34

Closed ryuslash closed 10 years ago

ryuslash commented 10 years ago

Hi,

Thanks for writing this package, it's really useful. Though the one thing that's keeping me from using flx more is the fact that it can't open files in another window. This patch remedies that. The fiplr-find-*-other-frame commands were added for consistency.

I thought that a macro could be used here to reduce the lines of code, but I am uncertain if that would really help maintainability. If you disagree, I can easily change this code to use a macro.

Please let me know what you think.

d11wtq commented 10 years ago

This looks awesome, thanks! I'll give it quick spin, then merge if it works on my end (looks good from a quick source review).

d11wtq commented 10 years ago

It seems to work, although the first time I run fiplr-find-file-other-window, I get an error:

Error in post-command-hook (completion-in-region--postch): (wrong-type-argument buffer-or-string-p fiplr-find-file-other-window)

Let me see if I can fix that, unless you beat me to it.

d11wtq commented 10 years ago

Actually, never mind, the issue I'm getting above only happens when I use evil-mode's ex command style of invoking the command, so something else is up there. LGTM, merged :)

ryuslash commented 10 years ago

Great! Thanks for including my patch.