grokability / jamf2snipe

Import and sync assets from a JAMFPro instance to Snipe-IT asset management.
MIT License
114 stars 55 forks source link

Speed up user lookups, exact match only on checkout (user flag), syntax & typo fixes #40

Closed christovic closed 4 years ago

christovic commented 4 years ago

User facing changes:

Addition of --no_search should help with Fixes #25

Behind the scenes:

get_snipe_users is a new function that returns the rows of users from Snipe get_snipe_user_id has been updated to reference 'snipe_users' before referring to the API

Might want to refine this before merging into master in case some try to use realname instead of email or something... It'll just grab the first case insensitive match in that array. Could make it faster by saying you know what field you want to match to in Snipe.

Fixes #39

Typo & Syntax Fixes #38 Fixes #37 Fixes #36

ParadoxGuitarist commented 4 years ago

Thanks Dan!