search

grommet / grommet-theme-hpe

Hewlett Packard Enterprise grommet theme
Apache License 2.0
23 stars 12 forks source link

Add `background-selected-subtle` and `background-selected-subtle-hover` #396

Open britt6612 opened 6 months ago

britt6612 commented 6 months ago

What does this PR do?

adds background for select and select hover to allow for easier color contrast accessibility in Select component.

What testing has been done on this PR?

on the site

Any background context you want to provide?

https://github.com/grommet/grommet-theme-hpe/issues/390

What are the relevant issues?

https://github.com/grommet/grommet-theme-hpe/issues/390

Screenshots (if appropriate)

Is this change backward compatible or could it be a breaking change for the official HPE theme?

change

How should this PR be communicated in the release notes?

britt6612 commented 6 months ago

https://github.com/grommet/grommet-theme-hpe/assets/42451602/c27d2043-ed12-4f3c-b756-34788eaa680b

taysea commented 6 months ago

It looks like these colors don't meet the contrast ratio requirements

https://www.w3.org/WAI/WCAG22/Understanding/non-text-contrast.html

@jcfilben I double checked this and they seem fine-- can you clarify where you were seeing a failure?

Screen Shot 2024-05-14 at 3 35 34 PM Screen Shot 2024-05-14 at 3 35 14 PM
taysea commented 6 months ago

Converting to draft, I misunderstood Jessica's comment but she noted that the selected box itself does not meet color contrast with the unselected boxes.