fix banner landmark violations - Githubissues

grommet / hpe-design-system

HPE Design System

48 stars 24 forks source link

fix banner landmark violations #4429

Closed britt6612 closed 1 week ago

britt6612 commented 1 week ago

What does this PR do?

This PR adds a main to stories to fix having one landmark banner

Where should the reviewer start?

storybook examples

What testing has been done on this PR?

local storybook In addition to the feature you are implementing, have you checked the following:

General UX Checks

[ ] Small, medium, and large screen sizes
[ ] Cross-browsers (FireFox, Chrome, and Safari)
[ ] Light & dark modes
[ ] All hyperlinks route properly

Accessibility Checks

[ ] Keyboard interactions
[ ] Screen reader experience
[ ] Run WAVE accessibility plugin (Chrome)

Code Quality Checks

[ ] Console is free of warnings and errors
[ ] Passes E2E commit checks
[ ] Visual snapshots are reasonable

How should this be manually tested?

storybook

Any background context you want to provide?

What are the relevant issues?

closes #4360 closes https://github.com/grommet/grommet/issues/7422

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

netlify[bot] commented 1 week ago

Deploy Preview for unrivaled-bublanina-3a9bae ready!

Name	Link
Latest commit	57f352e11ba5a2480078f657860b087d419a0e70
Latest deploy log	https://app.netlify.com/sites/unrivaled-bublanina-3a9bae/deploys/673ceb5e5a09fe0008fb16a4
Deploy Preview	https://deploy-preview-4429--unrivaled-bublanina-3a9bae.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.