Question about "derivative()" method in class "ExpressionSqrt"

groops-devs / groops

A software toolkit for gravity field recovery and GNSS processing

GNU General Public License v3.0

172 stars 102 forks source link

Question about "derivative()" method in class "ExpressionSqrt" #246

Closed MrSoul8715 closed 3 months ago

MrSoul8715 commented 3 months ago

Hi, I've meet some problem when reading code "derivative()" in file "expressionParser.cpp". In this method, the statement "return operand->derivative(var)/sqrt(operand->clone());" seems to be wrong. The correct way maybe "*return operand->derivative(var)/ (exprValue(2.0)sqrt(operand->clone()));**". Thanks for reading.

tmayerguerr commented 3 months ago

Hi, You are right. We fixed the bug. Thanks for your help. Best regards Torsten