Introduce python logging module

grote / osm2gtfs

Turn OpenStreetMap data and schedule information into GTFS

GNU General Public License v3.0

98 stars 31 forks source link

Introduce python logging module #142

Closed pantierra closed 6 years ago

pantierra commented 6 years ago

This is a PR related to issue #46 - Improve debugging by introducing python's logging module.

nlehuby commented 6 years ago

There are still a few print that could be changed to logging messages in the following files:

core/osm_connector.py
creators/trips_creator.py

pantierra commented 6 years ago

Thanks! Transformed the print into logging.info and rebased the PR on latest master.

pantierra commented 6 years ago

It had again a little conflict after the latest PR has been accepted. Rebased again.

grote commented 6 years ago

Do you have any idea why the CI is failing on this branch only?

pantierra commented 6 years ago

No. I basically just rebased. Looks a bit like a strange error.

grote commented 6 years ago

Could it be that the tests run a long time and now there's no more output where there was output before?

pantierra commented 6 years ago

Yes, indeed. The logging level was not being set properly when running the tests, and fell back to the standard WARNING, which was not giving that regular output. Now, for tests the logging level INFO is set, too, and tests run successfully \o/