grough / lilac-loop-vcv

Live looping plugin for VCV Rack
https://library.vcvrack.com/LilacLoop
GNU General Public License v3.0
14 stars 4 forks source link

"save audio with patch" doesn't reload the audio file when the patch is reopened in some case #10

Open terrytheplatypus opened 2 years ago

terrytheplatypus commented 2 years ago

On some previous patches i tried, save audio with patch worked fine but with a recent patch setup i was using, the audio file doesn't reload when the patch is closed and reopened. i will attach the patch example.

grough commented 2 years ago

If you can provide the simplest possible patch that reproduces the problem consistently, that would be much appreciated.

terrytheplatypus commented 2 years ago

here's how i was using it,if you use the big vult knob you can record on several channels, then close and reopen. i realized the problem is that not exactly that it doesn't reload, but it only reloads once the big toggle button is pressed after the patch is reloaded, and when it reloads, the different channels play not in the correct timing. lilacbrokendemo.zip .

terrytheplatypus commented 2 years ago

this might be happening only when switching audio drivers in the audio module, though i don't see why that would affect it. have to test it some more. i was switching drivers because i was mixing with an audio interface through speakers and i just wanted it to render through the pc audio speakers. additionally, when this issue happens, it's accompanied by weird pops in the exported audio file. i might try debugging this at some point, it might be a bug with the audiofile library you're using.

nealsanche commented 2 years ago

I had this happen to me yesterday. It was the second time I used Looper, and I was cautious and exported all of the loops, switched to auto save with patch (which wasn't on by default), then saved the song, and after closing VCV and reopening, the loops were no longer running. I couldn't figure out how to reload the exported audio easily, so I used another module to get things running again.

nealsanche commented 2 years ago

I think in my case I had duplicated a looper after recording to it. I haven't had it happen since.

mysterybear commented 1 year ago

same here

seems like it'd be really useful to be able to load audio files into Looper through the context menu so that we can work around this if/when it happens?

would you accept a PR with this feature @grough ?