groupon / cson-parser

Simple & safe CSON parser
BSD 3-Clause "New" or "Revised" License
133 stars 27 forks source link

coffee-script renamed to coffeescript, update dependencies #67

Closed tavikukko closed 6 years ago

tavikukko commented 6 years ago

https://www.npmjs.com/package/coffee-script

jkrems commented 6 years ago

Thanks a lot for the ping! Hadn't realized they changed the name of the package. We'll have to verify if the parser API changed during the 2.0 update.

julkue commented 6 years ago

I have the same situation. npm install fails due to this "UNMET DEPENDENCY"

jkrems commented 6 years ago

Oh, didn't realize they removed something from the registry..? I just tried and I can still install cson-parser.

@julmot Do you have a repro for that error? I tried installing cson-parser and it seems to work:

> npm i cson-parser

> coffee-script@1.12.8 postinstall /private/tmp/node_modules/coffee-script
> node --eval 'if (require("./package.json").name === "coffee-script") { var red, yellow, cyan, reset; red = yellow = cyan = reset = ""; if (!process.env.NODE_DISABLE_COLORS) { red = "\x1b[31m"; yellow = "\x1b[33m"; cyan = "\x1b[36m"; reset = "\x1b[0m"; } console.warn(red + "CoffeeScript has moved!" + reset + " Please update references to " + yellow + "\"coffee-script\"" + reset + " to use " + yellow + "\"coffeescript\"" + reset + " (no hyphen) instead."); console.warn("Also, a new major version has been released under the " + yellow + "coffeescript" + reset + " name on NPM. This new release targets modern JavaScript, with minimal breaking changes. Learn more at " + cyan + "http://coffeescript.org" + reset + "."); console.warn(""); }'

CoffeeScript has moved! Please update references to "coffee-script" to use "coffeescript" (no hyphen) instead.
Also, a new major version has been released under the coffeescript name on NPM. This new release targets modern JavaScript, with minimal breaking changes. Learn more at http://coffeescript.org.

npm WARN saveError ENOENT: no such file or directory, open '/private/tmp/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open '/private/tmp/package.json'
npm WARN tmp No description
npm WARN tmp No repository field.
npm WARN tmp No README data
npm WARN tmp No license field.

+ cson-parser@2.0.0
added 2 packages in 6.79s

Ignoring that super annoying warning they added.

jkrems commented 6 years ago

Ugh, they did the same thing that broke stuff all over the place with babel. Just... why..? :(

We'll see what we can do from our side but I would suggest locking yourself to a pre-warning version of coffee-script right now as a workaround.

julkue commented 6 years ago

I would suggest locking yourself to a pre-warning version

Thanks for your reply. Can you please elaborate this a bit?

jkrems commented 6 years ago

Sure! In your app's package.json you can add a dependency on a specific version of coffee-script (no ~ or ^). If it fits the version range of cson-parser, you can force it to use that version instead of latest. I assume the warning was added in some recent patch release.

julkue commented 6 years ago

Ah I see @jkrems what you mean. Unfortunately I can't do that, since I'm not directly depending on cson-parser:

topic

So I guess everything I can do is wait until cson-parser depends on a backwards-compatible version, then I'd have to contact the owners of applause and grunt-replace to also update their dependencies and finally also wait for a grunt dependency update (https://github.com/gruntjs/grunt/issues/1611).

Or do you see any other way?

julkue commented 6 years ago

https://github.com/jashkenas/coffeescript/issues/4805

julkue commented 6 years ago

fyi: It works now, due to this fix: https://github.com/jashkenas/coffeescript/issues/4805#issuecomment-348237307

mojavelinux commented 6 years ago

Can we please get a new release of cson-parser? This warning is driving us all crazy. I get support tickets all the time that the install command for my application is broken because users think the warning means the install failed.

mojavelinux commented 6 years ago

Btw, I recognize that the coffee-script (or coffeescript) project screwed up, but it's done now and we have to deal with the problem that exists now.

jkrems commented 6 years ago

There should be a 3.0.0 soon now that includes coffeescript.

P.S.: In case any Groupon employees read this: Please don't upgrade, we still have a bunch of coffee-script references in our dependency tree.

mojavelinux commented 6 years ago

@jkrems Thank you!