groupon / node-cached

A simple caching library for node.js, inspired by the Play cache API
BSD 3-Clause "New" or "Revised" License
94 stars 15 forks source link

refactor: rewrite, use memcached-elasticache & drop Node 8 #48

Closed aaarichter closed 3 years ago

aaarichter commented 4 years ago

BREAKING CHANGES:

General

Cache

cache

Backends

aaarichter commented 4 years ago

Hey @jkrems, @dbushong & @aotarola would you be so kind and have a look at this PR 😼 . Thanks

dbushong commented 4 years ago

If you're making breaking API changes, is there any reason to continue to support callback syntax?

Also, for the things that now return promises, you should review the README to make sure it's clear about callback use.

dbushong commented 4 years ago

OK, I'm thru with a quick once-over.

aaarichter commented 3 years ago

If you're making breaking API changes, is there any reason to continue to support callback syntax?

yes you are right, it would make sense to further simplify the code by dropping callback syntax

aaarichter commented 3 years ago

Hey @dbushong @aotarola

sorry it took so long to address your feedback. Would you do another review? 🙇‍♂️

I rebased and updated the PR.