Closed aaarichter closed 3 years ago
Hey @jkrems, @dbushong & @aotarola would you be so kind and have a look at this PR 😼 . Thanks
If you're making breaking API changes, is there any reason to continue to support callback syntax?
Also, for the things that now return promises, you should review the README to make sure it's clear about callback use.
OK, I'm thru with a quick once-over.
If you're making breaking API changes, is there any reason to continue to support callback syntax?
yes you are right, it would make sense to further simplify the code by dropping callback syntax
Hey @dbushong @aotarola
sorry it took so long to address your feedback. Would you do another review? 🙇♂️
I rebased and updated the PR.
lodash
andbluebird
Cache
with ES6 class syntaxcache.set
no longer returns a valuenoop
backend and makememory
the default backendcache.set
values as described in README.mdname
was not a string. It will throw a type error now.memcached-elasticache
instead ofmemcached
BREAKING CHANGES:
General
memcached-elasticache
with AWS support instead ofmemcached
. See https://github.com/jkehres/memcached-elasticache#readmeBluebird
.cached()
needs to be called with a string argument as name. If thename
argument is undefined, it will fallback to"default"
.Cache
Cache.setBackend()
no longer returns the created backend.Cache.getWrapped()
is removed.Cache.applyPrefix
Cache.end
Cache.prepareOptions
Cache.setBackend
cache
cache.set()
,cache.get()
,cache.getOrElse()
,cache.unset()
no longer support the callback argument. Use them as promise.cache.set()
no longer returns a value.cache.set(key, value)
accepts functions and promises as value.Backends
Memcached
.addType()
does not return backend class anymore.