groupon / selenium-download

allow downloading of latest selenium standalone server and chromedriver
BSD 3-Clause "New" or "Revised" License
28 stars 25 forks source link

Path must be a string #19

Closed geraldbaeck closed 8 years ago

geraldbaeck commented 8 years ago

I got this by running this script:

var selenium = require('selenium-download'); selenium.ensure('./bin', function(error) { if (error) { return callback(error); } });

[testium] grabbing selenium standalone server 2.43.0 path.js:7 throw new TypeError('Path must be a string. Received ' + inspect(path)); ^

TypeError: Path must be a string. Received { url: 'http://selenium-release.storage.googleapis.com/2.43/selenium-server-standalone-2.43.0.jar', name: 'selenium_2.43.0.jar' } at assertPath (path.js:7:11) at Object.basename (path.js:1355:5) at /Users/geraldback/Dropbox/dev/BäckBlog/node_modules/selenium-download/node_modules/download/index.js:35:43 at each (/Users/geraldback/Dropbox/dev/BäckBlog/node_modules/selenium-download/node_modules/each-async/each-async.js:63:4) at module.exports (/Users/geraldback/Dropbox/dev/BäckBlog/node_modules/selenium-download/node_modules/download/index.js:33:5) at module.exports (/Users/geraldback/Dropbox/dev/BäckBlog/node_modules/selenium-download/lib/download.js:58:12) at module.exports (/Users/geraldback/Dropbox/dev/BäckBlog/node_modules/selenium-download/lib/selenium/download.js:56:12) at /Users/geraldback/Dropbox/dev/BäckBlog

jkrems commented 8 years ago

@geraldbaeck Which version of node are you using? Is this node 6?

geraldbaeck commented 8 years ago

@jkrems v6.1.0

edit: It worked with v5.9.0

arypurnomoz commented 8 years ago

i also has this problem with node v6.2.1

jkrems commented 8 years ago

Thanks for the report! That's what we get for waiting for LTS time until we properly test node versions. :) We'll look into fixing this in the near future but if anybody wants to get their hands dirty on this, we'd definitely accept PRs.

jkrems commented 8 years ago

Actually, this repo was due for a JavaScript conversion anyhow. https://github.com/groupon/selenium-download/pull/27