search

grpc / grpc-dart

The Dart language implementation of gRPC.
https://pub.dev/packages/grpc
Apache License 2.0
861 stars 271 forks source link

Add GrpcOrGrpcWebClientChannel (#457) #479

Closed morgwai closed 3 years ago

morgwai commented 3 years ago

size XXL is due to generated/copied proto files (~700 lines). The real code including tests and example is ~350 lines.

morgwai commented 3 years ago

looking at the number of warnings generated by the example, I'm wondering if it would be better to move it to a separate repo: please advise.

mraleph commented 3 years ago

@morgwai I think you should be able to make an example which does not depend on Flutter or just drop the example altogether for now.

morgwai commented 3 years ago

@mraleph thanks for the comments :-) Please have another look in a spare moment.

mraleph commented 3 years ago

LGTM, waiting for the workflow to run.

morgwai commented 3 years ago

sorry for the analyze error: neither android-studio nor running from command line reported it for me:

grpc-dart$ dart analyze --fatal-infos . Analyzing .... 1.7s No issues found!

does the github check have some additional options that I should add to catch this issue in the future?

mraleph commented 3 years ago

It uses both stable and dev release of Dart - so I think it fails on dev where linter has been updated.

mraleph commented 3 years ago

One last request: please add an item to CHANGELOG describing the change. I think it is a great change to include into the changelog.

morgwai commented 3 years ago

@mraleph Passed :) I don't see a 'merge' button or anything: I think you need to merge it.

morgwai commented 3 years ago

One last request: please add an item to CHANGELOG describing the change. I think it is a great change to include into the changelog.

ah yes: 3 minutes please :)

morgwai commented 3 years ago

@mraleph should I add under 3.0.1-dev version, or some other?

mraleph commented 3 years ago

Yep under the 3.0.1-dev.

morgwai commented 3 years ago

@mraleph pushed, please start the workflow.

morgwai commented 3 years ago

@mraleph ready to merge :) Many thanks for the review!

ericbets commented 2 years ago

Can anyone comment on what happened to this? It says merged but I can't find it anywhere.

mraleph commented 2 years ago

@ericbets it's right here: https://github.com/grpc/grpc-dart/blob/master/lib/grpc_or_grpcweb.dart, you need to be using 3.0.1 or later to get it.