search

grpc / grpc-dart

The Dart language implementation of gRPC.
https://pub.dev/packages/grpc
Apache License 2.0
860 stars 271 forks source link

Make ResponseStream a regular class #642

Closed aran closed 1 year ago

aran commented 1 year ago

Reverts part of https://github.com/grpc/grpc-dart/commit/d9553ca73f66116f7ad14fff5d0e4814253311a4

Making ResponseStream a base class is not backward-compatible and makes it hard or impossible to work around https://github.com/grpc/grpc-dart/issues/413.

Arguably, ResponseStream and ResponseFuture are serving two purposes: "The interface interceptors need to work with" and the base of implementations that have ClientCall state. A backwards-compatible future change could in principle separate an interface and a base class to decouple these.

linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

kevmoo commented 1 year ago

The problem: this now fails with Dart 3.1-dev – ugh.

kevmoo commented 1 year ago

This will break with the latest dev release, but we can cross that bridge soon.

kevmoo commented 1 year ago

This will NOT break. I have an old SDK setup locally. User error. Sorry!