Closed wabalubdub closed 2 months ago
Hi, thanks for the PR.
FYI this is just one file of many with logs. See https://github.com/search?q=repo%3Agrpc%2Fgrpc-dotnet+LoggerMessage.Define&type=code
You're welcome to update more if you'd like or stick with this one. I'll close the issue once all are updated.
Hey, of course! I ordered the methods according to Event ID. I didn't notice there were more, ill work on the rest of them. would you rather i update the rest of the in this PR? I can probably get to all of them tomorrow.
One pr is fine
Hey I updated the PR to include changes to all the files that have the LoggerMessage.Define
syntax.
A couple notes:
ToString()
I kept the original function signature and made a call to a private generated log after the formatting. The LoggerMessage Attribute doesn't seem to have a way to access member variables of objects that are passed to it so I couldn't generate the formatting automatically as well. logger.isTraceEnabled()
Thanks! Looks good to me. There are a lot of changes so I haven't excuasively checked every log, but the ones I did look at were correct.
This PR uses the generated logs feature to simplify and reduce the log declarations.
closes #2529
Also my first PR so feedback would be lovely.