search

grpc / grpc-go

The Go language implementation of gRPC. HTTP/2 based RPC
https://grpc.io
Apache License 2.0
20.93k stars 4.34k forks source link

google.golang.org/grpc v1.66.1 is missing a retraction #7618

Closed mx-psi closed 2 weeks ago

mx-psi commented 2 weeks ago

The v1.66.1 tag is available on the pkg.go.dev docs domain and the official Go proxy (download here, sumdb entry here), but it looks like the tag has been removed from this repository.

This breaks build for anyone that is not using the official Go proxy and is building a module that has v1.66.1 on their dependency tree, it breaks automatic dependency tools like Dependabot and it breaks even people pinning commits if their pseudoversion has v1.66.1 as the base version. Would it be possible for this tag to be re-added to the repository to avoid this breakage? Thanks!

Similar issues on other projects for context:

As mentioned on this comment https://github.com/grpc/grpc-go/issues/7608#issuecomment-2340624446 the correct approach is to retract the version but keep the tag available.

dfawley commented 2 weeks ago

Sorry for the trouble. I have re-added the tag for 1.66.1. There is nothing in this release, but v1.66.2 should be released later today with some bug fixes.

mx-psi commented 2 weeks ago

Thank you! :pray: Would be great if v1.66.2 retracts v1.66.1 as well :)

dfawley commented 2 weeks ago

@mx-psi - I don't believe it's important to do a retraction here, since the v1.66.1 version is "fine" -- it reflects the proper version number in the user agent string, and it contains no regressions or unintended code. It is just the exact same as v1.66.0 except for the user agent string.

mx-psi commented 2 weeks ago

Thanks for clarifying :+1: that makes sense, I agree it can be kept as is then :)