Not working in Katest Nightly

[mayankleoboy1]

The addon doesnt seem to be working on the latest Nightly, with a new profile.
The addon hasnt been working for ~1Month now.

[mayankleoboy1]

and by not working, I mean the URL is not being converted to the "breadcrumb interafce"

[grssam]

1 month - not possible. The issue started happening 15 days ago. I will get to it soon.

[Yobby]

Has this issue now reached Aurora? As it's not working there since a few days either. (at the same time as the KeeFox addon stopped working, although there's a development-version available that fixed it.)

[amsterjanis]

Supposedly this is caused by this change.

Possible solutions (from the Firefox dev's announcement):

If you work with JS that contains let bindings, you may start encountering the following two errors:

1. TypeError: redeclaration of variable foo

   To fix, rename the variable or remove the extra let if you are assigning to an already-bound variable.

   These are static errors. You may pass your JS through the syntax checker in the SpiderMonkey shell (-c) to detect them.

2. ReferenceError: can't access let declaration `foo' before initialization

   These are hoisted uses and wacky cases like accessing a let binding declared in one switch case in a different case. To fix, don't do those things please.

   These are dynamic errors. You have to execute your JS to detect them.

I took a glance at the code and realized it's way over my head (as is any js over 30 LOC) so it might as well be something else entirely.

Anyhow, good luck tracking down the bug, this is the last broken plugin on my x64 Nightly and I'm missing it terribly as there are no alternatives with comparable functionality. If the bug is on Aurora now, it'll soon reach Beta.

[mzso]

It doesn't work here either. At first I thought it might be electrolysis. But it doesn't even work when I turn that off.

@mayankleoboy1 commented on 2014. szept. 28. 15:00 CEST:

and by not working, I mean the URL is not being converted to the "breadcrumb interafce"

BTW. Can the issue be renamed? "Katest" looks silly.

[jerone]

The "latest nightly" is probably now in the beta channel.

Confirm not working on FF 35 beta 1. Love to see it working again. Very useful addon!

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0

[UndarkAido]

I can confirm that it isn't working in 35.0

[tophf]

fixed version: https://github.com/tophf/UIEnhancer/releases/tag/5.1fx35

[jerone]

@tophf commented on 6 dec. 2014 04:13 CET:

fixed version: https://github.com/tophf/UIEnhancer/releases/tag/5.1fx35

Please send a PR.

[amsterjanis]

tophf commented 13 hours ago

fixed version: https://github.com/tophf/UIEnhancer/releases/tag/5.1fx35

Works fine on 36.0a2 but somehow not on 37.0a1 (64-bit).

[tophf]

@jerone, as for PR, I'd like to base it on the latest commit, which didn't work at my first attempt. @amsterjanis, it works in latest 37x64 here (win7x64).

[amsterjanis]

@tophf, disabled every single extension, even removed userchrome, still nothing. I'll try to narrow it down, could just be the particular config.

[EDIT] Yep, works fine on a different machine, same profile and everything. Sorry for the confusion. If I manage to find the cause, I'll post it.

[tophf]

I've updated the fix once more - https://github.com/tophf/UIEnhancer/releases/tag/fx35_fix3 Now it's based on the latest commit and also includes the three required images used in the Options window, these images weren't present in the repo.

[amsterjanis]

amsterjanis commented 2 days ago

If I manage to find the cause, I'll post it.

So apparently enabling "Show the Status in the Location Bar." in the options breaks the add-on for me. Not a big deal, I just thought I'd mention it in case anyone else has the same issue.

[mzso]

Cool it works on Trunk and 34 too.

[grssam]

Hey, thanks for taking this up while I was busy. I will merge this tomorrow and see if I can fix the status bar issue too.