Closed sc250024 closed 1 week ago
Overall LGTM. Will trigger tests for this.
@james03160927 I get the following locally:
❯ go test -count=1 -parallel=10 ./...
? github.com/gruntwork-io/cloud-nuke [no test files]
? github.com/gruntwork-io/cloud-nuke/externalcreds [no test files]
? github.com/gruntwork-io/cloud-nuke/logging [no test files]
? github.com/gruntwork-io/cloud-nuke/telemetry [no test files]
ok github.com/gruntwork-io/cloud-nuke/aws 0.600s
? github.com/gruntwork-io/cloud-nuke/v2_migration_report [no test files]
ok github.com/gruntwork-io/cloud-nuke/aws/resources 20.318s
ok github.com/gruntwork-io/cloud-nuke/commands 0.701s
ok github.com/gruntwork-io/cloud-nuke/config 0.449s
ok github.com/gruntwork-io/cloud-nuke/report 0.833s
ok github.com/gruntwork-io/cloud-nuke/ui 0.530s
ok github.com/gruntwork-io/cloud-nuke/util 0.675s
Ready to merge when you are!
Description
Fixes #770.
TODOs
Read the Gruntwork contribution guidelines.
nuke_sandbox
andnuke_phxdevops
jobs in.circleci/config.yml
have been updated with appropriate exclusions (either directly in the job or via the.circleci/nuke_config.yml
file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.Release Notes (draft)
Updated
snapshot
to AWS SDK v2