gruntwork-io / cloud-nuke

A tool for cleaning up your cloud accounts by nuking (deleting) all resources within it
https://gruntwork.io/
MIT License
2.81k stars 358 forks source link

Migrate Snapshot to AWS SDK v2 #787

Closed sc250024 closed 1 week ago

sc250024 commented 1 week ago

Description

Fixes #770.

TODOs

Read the Gruntwork contribution guidelines.

Release Notes (draft)

Updated snapshot to AWS SDK v2

sc250024 commented 1 week ago

Overall LGTM. Will trigger tests for this.

@james03160927 I get the following locally:

❯ go test -count=1 -parallel=10 ./...
?       github.com/gruntwork-io/cloud-nuke  [no test files]
?       github.com/gruntwork-io/cloud-nuke/externalcreds    [no test files]
?       github.com/gruntwork-io/cloud-nuke/logging  [no test files]
?       github.com/gruntwork-io/cloud-nuke/telemetry    [no test files]
ok      github.com/gruntwork-io/cloud-nuke/aws  0.600s
?       github.com/gruntwork-io/cloud-nuke/v2_migration_report  [no test files]
ok      github.com/gruntwork-io/cloud-nuke/aws/resources    20.318s
ok      github.com/gruntwork-io/cloud-nuke/commands 0.701s
ok      github.com/gruntwork-io/cloud-nuke/config   0.449s
ok      github.com/gruntwork-io/cloud-nuke/report   0.833s
ok      github.com/gruntwork-io/cloud-nuke/ui   0.530s
ok      github.com/gruntwork-io/cloud-nuke/util 0.675s

Ready to merge when you are!