improve shots tracking - Githubissues

gruppe-adler / grad-replay

Records player and AI movment and replays at the end of the mission.

GNU General Public License v3.0

8 stars 1 forks source link

improve shots tracking #41

Closed McDiod closed 4 years ago

McDiod commented 4 years ago

Currently only the unit's first shot fired during a save interval is being tracked. This changes that so that all shots are being tracked until the first tracking of the interval is complete - meaning the first shot to land will be the one being saved.

Pros

if a tracked shot ricocheted in the old system, it would block all further shots from being tracked until it landed
shots that are way off target and go kilometers through the air before landing are now more unlikely to be the ones that are being saved

Cons

~~worse performance, because multiple shots will be tracked simultaneously~~

McDiod commented 4 years ago

I just performance tested this. There is no noticeable difference during the recording. Setup was 70 AI suppressing a target.

{
    _x disableAI "COVER";
    _x disableAI "AUTOCOMBAT";
    _x doSuppressiveFire suppressTarget;
} forEach allUnits;

Results without improvements: https://youtu.be/ujTq0mKciVQ

Results with improvements: https://youtu.be/LHObpmmlSE8

As you can see, shots that are off target are now less likely to be saved to the replay.