search

gs-akhan / react-native-chooser

Simple Cross Platform HTML Select Tag for react-native
MIT License
154 stars 47 forks source link

V2 RoadMap #22

Open gs-akhan opened 7 years ago

gs-akhan commented 7 years ago

Hi, These are the features being targeted for V2

Thanks

st0ffern commented 7 years ago

How about a dropdown instead of a modal overlay?

gs-akhan commented 7 years ago

Yeah Good question. But positioning is one hell of thing. I have contributed at lot to https://github.com/alinz/react-native-dropdown.

But the problem is when we embed the component inside navigator or otherviews the top and left positions are relative to parent component. So what I thought is to have a complete view for selection. It is easy UX wise too and also coding wise.

We can have that options too, if we collectively decide.

rostislav-simonik commented 7 years ago

@gs-akhan Have you had chance to validate my sample for setSelectedText #20 alternative through props ? Would you like me to create pull request for given approach?

st0ffern commented 7 years ago

@gs-akhan i will fix v2 by this week, just need to land a few things @ work

gs-akhan commented 7 years ago

Cool. Create a branch we both can share the features and implement them

On Mon, May 15, 2017 at 7:07 PM, Kristoffer notifications@github.com wrote:

@gs-akhan https://github.com/gs-akhan i will fix v2 by this week, just need to land a few things @ work

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gs-akhan/react-native-chooser/issues/22#issuecomment-301477056, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYnVuCQVuPYo_tzCjZAlnYT6z2Nwy3zks5r6FUogaJpZM4NaKPK .

gs-akhan commented 7 years ago

@rostislav-simonik I havent. will do it tonight.

rostislav-simonik commented 7 years ago

@gs-akhan Ok, thanks, let me know then and I'll do a more clean proposal.

st0ffern commented 7 years ago

@gs-akhan can you add me as collaborator on NPM? Also activate Travis on the repo 😉

I am starting with v2 now

gs-akhan commented 7 years ago

Sure sir !! On Sun, 21 May 2017 at 1:03 PM, Kristoffer notifications@github.com wrote:

@gs-akhan https://github.com/gs-akhan can you add me as collaborator on NPM? Also activate Travis on the repo 😉

I am starting with v2 now

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gs-akhan/react-native-chooser/issues/22#issuecomment-302920506, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYnVtSNx--LkqKotljrQbOSeSS2B4wwks5r7-i6gaJpZM4NaKPK .

gs-akhan commented 7 years ago

@stoffern What's your NPM profile name ?

st0ffern commented 7 years ago

https://www.npmjs.com/~stoffern

st0ffern commented 7 years ago

added direction (fromLeft, fromRight, fromTop, fromBottom) and renderButton={ currentValue => <Text>{'Current Value: ' + currentValue}</Text> }

more to come later on v2

gs-akhan commented 7 years ago

Did You get access ?

On Sun, May 21, 2017 at 3:51 PM, Kristoffer notifications@github.com wrote:

added direction (fromLeft, fromRight, fromTop, fromBottom) and renderButton={ currentValue => {'Current Value: ' + currentValue} }

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gs-akhan/react-native-chooser/issues/22#issuecomment-302927785, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYnVpHzBQmksMUrqMMR8iZn3OpMiAPnks5r8BAtgaJpZM4NaKPK .

gs-akhan commented 7 years ago

Activated Travis

On Sun, May 21, 2017 at 3:53 PM, Azhar uddin akhan@gainsight.com wrote:

Did You get access ?

On Sun, May 21, 2017 at 3:51 PM, Kristoffer notifications@github.com wrote:

added direction (fromLeft, fromRight, fromTop, fromBottom) and renderButton={ currentValue => {'Current Value: ' + currentValue} }

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gs-akhan/react-native-chooser/issues/22#issuecomment-302927785, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYnVpHzBQmksMUrqMMR8iZn3OpMiAPnks5r8BAtgaJpZM4NaKPK .

st0ffern commented 7 years ago

i feed we should remove sending styles into the Select and rather let the user send custom components into it with styles..

This is for SelectButton and Options

st0ffern commented 7 years ago

passing it like this:

renderButton={ currentValue => <Text>{'Current Value: ' + currentValue}</Text> }
renderOptionItem = { ({value, text, index}) => <View key={index} style={{}}>{text}</View>}
renderOptionSeperator={ data => <View style={{height: 1, backgroundColor: 'black'}}></View>}
gs-akhan commented 7 years ago

How would end API look like.. ? Are we getting rid of Component then, and then replacing it with renderOptionItem ?

On Sun, May 21, 2017 at 5:18 PM, Kristoffer notifications@github.com wrote:

passing it like this:

renderButton={ currentValue => {'Current Value: ' + currentValue} } renderOptionItem = { ({value, text, index}) => {text}} renderOptionSeperator={ data => <View style={{height: 1, backgroundColor: 'black'}}>}

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gs-akhan/react-native-chooser/issues/22#issuecomment-302931808, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYnVucNuZGd-SLr_xaapY0SQkr9J5PXks5r8CSKgaJpZM4NaKPK .

gs-akhan commented 7 years ago

Ohh Got it. Lets accept styles. that should not be a worry.

On Sun, May 21, 2017 at 5:20 PM, Azhar uddin akhan@gainsight.com wrote:

How would end API look like.. ? Are we getting rid of Component then, and then replacing it with renderOptionItem ?

On Sun, May 21, 2017 at 5:18 PM, Kristoffer notifications@github.com wrote:

passing it like this:

renderButton={ currentValue => {'Current Value: ' + currentValue} } renderOptionItem = { ({value, text, index}) => {text}} renderOptionSeperator={ data => <View style={{height: 1, backgroundColor: 'black'}}>}

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gs-akhan/react-native-chooser/issues/22#issuecomment-302931808, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYnVucNuZGd-SLr_xaapY0SQkr9J5PXks5r8CSKgaJpZM4NaKPK .

gs-akhan commented 7 years ago

Passing Component would be little too much to do for users. I think so

On Sun, May 21, 2017 at 5:27 PM, Azhar uddin akhan@gainsight.com wrote:

Ohh Got it. Lets accept styles. that should not be a worry.

On Sun, May 21, 2017 at 5:20 PM, Azhar uddin akhan@gainsight.com wrote:

How would end API look like.. ? Are we getting rid of Component then, and then replacing it with renderOptionItem ?

On Sun, May 21, 2017 at 5:18 PM, Kristoffer notifications@github.com wrote:

passing it like this:

renderButton={ currentValue => {'Current Value: ' + currentValue} } renderOptionItem = { ({value, text, index}) => {text}} renderOptionSeperator={ data => <View style={{height: 1, backgroundColor: 'black'}}>}

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gs-akhan/react-native-chooser/issues/22#issuecomment-302931808, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYnVucNuZGd-SLr_xaapY0SQkr9J5PXks5r8CSKgaJpZM4NaKPK .

st0ffern commented 7 years ago

It's a normal practise to do in React. Look at ListView and FlatList I think if you dont pass in a custom component it will just render default layout..

So it is optional

gs-akhan commented 7 years ago

Let's go with it .. once it is all done we will see if we can make it even simpler On Sun, 21 May 2017 at 5:49 PM, Kristoffer notifications@github.com wrote:

It's a normal practise to do in React

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gs-akhan/react-native-chooser/issues/22#issuecomment-302933328, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYnVgtBswr6MO2vNKE3KufMdYNu3RORks5r8CvsgaJpZM4NaKPK .

rostislav-simonik commented 7 years ago

@gs-akhan @stoffern Hi guys, what about the change I have been proposing. The one which substitutes setSelectedText with props logic?

st0ffern commented 7 years ago

@rostislav-simonik i am rewriting the Select totally, into v2. There will be no setSelectText 😉

st0ffern commented 7 years ago

@gs-akhan how do you want to solve the multiple select? What should the user do after he has selected multiple items in order to confirm selections?

gs-akhan commented 7 years ago

@rostislav-simonik Yeaah your concerns are taken care by @stoffern 's fix.

@stoffern
So the API for multiselect should be based of prop multiple = true just like we have in HTML Select tag.

And selected values should be as array of options selected.

st0ffern commented 7 years ago

Yes, but when is the user done selecting?

gs-akhan commented 7 years ago

yes. That should be ok. You have any suggestions ?

On Mon, May 22, 2017 at 5:05 PM, Kristoffer notifications@github.com wrote:

Yes, but when is the user done selecting?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gs-akhan/react-native-chooser/issues/22#issuecomment-303075064, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYnVkutfCiyS-VxnDxqTw4D6VzISfg_ks5r8XLxgaJpZM4NaKPK .

st0ffern commented 7 years ago

Then er need a "done" button?

gs-akhan commented 7 years ago

No, we can close the menu my tapping anywhere outside. the will trigger "close" dropdown

On Mon, May 22, 2017 at 5:11 PM, Kristoffer notifications@github.com wrote:

Then er need a "done" button?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gs-akhan/react-native-chooser/issues/22#issuecomment-303076337, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYnVmwgpYdhCrHQ8O71OLLNVMBQXLsiks5r8XRygaJpZM4NaKPK .

st0ffern commented 7 years ago

done

st0ffern commented 7 years ago

I think "Searching options" should be a v3.. Lets keep changes to a minimum in v2 and making it compatible for upgrades..

There are breaking changes in v2, but they are also taking future updates into conciderations so they will not be breaking later on. cc @gs-akhan

gs-akhan commented 7 years ago

Perfect. I am good with that.. Is every thing committed to v2 branch ?

On Mon, May 22, 2017 at 6:45 PM, Kristoffer notifications@github.com wrote:

I think "Searching options" should be a v3.. Lets keep changes to a minimum in v2 and making it compatible for upgrades..

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gs-akhan/react-native-chooser/issues/22#issuecomment-303096513, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYnVgCSUbmzTYnHQLTi6_uwCHJZLvDgks5r8YpdgaJpZM4NaKPK .

st0ffern commented 7 years ago

yup, needs some testing.. I will fix Travis testings and README.md + MIGRATION.md later today

gs-akhan commented 7 years ago

I can test tonight from that branch ..

On Mon, May 22, 2017 at 7:08 PM, Kristoffer notifications@github.com wrote:

yup, needs some testing.. I will fix Travis testings and README.md + MIGRATION.md later today

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gs-akhan/react-native-chooser/issues/22#issuecomment-303102418, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYnVm3uvQ1Z3LUwc0fOOPvbBNf6hUTWks5r8Y-7gaJpZM4NaKPK .

rtman commented 7 years ago

@gs-akhan I realize this is a few months old by now but do you still have plans to release v2?

gs-akhan commented 7 years ago

@rtman Yes we would like you. The thing is we need some beta testers who can validate if its working well. If you wish to help it. we can make a release.

Thanks

rtman commented 7 years ago

@gs-akhan Hey I'm willing to test it in my app, I can't guarantee I can help too much in any debug but I can report what is happening. My time is a bit limited at the moment since I am developing full time with a deadline looming.

gs-akhan commented 7 years ago

@rtman Absolutely yes sir. :)

st0ffern commented 6 years ago

Back from a longer vacation 😉 what is the status of v2 ? 😄

st0ffern commented 6 years ago

Should i continue on this one?

gs-akhan commented 6 years ago

Yes.. with full force

On Fri, Dec 8, 2017 at 1:17 PM, Kristoffer notifications@github.com wrote:

Should i continue on this one?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gs-akhan/react-native-chooser/issues/22#issuecomment-350196594, or mute the thread https://github.com/notifications/unsubscribe-auth/AFYnViM9pNSIrO9wZhYa_np_bTbgzR_wks5s-OmugaJpZM4NaKPK .