gsantner / markor

Text editor - Notes & ToDo (for Android) - Markdown, todo.txt, plaintext, math, ..
https://github.com/gsantner/markor/discussions/2269
Other
3.78k stars 363 forks source link

Title bar extends into status bar, Android 15 #2387

Open 6058aa27-6ced-4d77-952a-bf55d59351c2 opened 2 months ago

6058aa27-6ced-4d77-952a-bf55d59351c2 commented 2 months ago

⚠️ This issue respects the following points: ⚠️

Description

When entering a file or the settings, the app takes up the whole screen rather than just the space below the status bar, making the UI at the top uninteractable and making it look odd.

Steps to reproduce

  1. Enter the settings menu through the three dots.
  2. The UI extends under the status bar

Information

Android version: Android 15 Device: Google Pixel 6 App Version: v2.12.5-0934 (240802)

Images for reference:

Source

git master branch

Format / File type

Not specific

Additional info / Log

No response

harshad1 commented 2 months ago

I am on a pixel 7 and I do not see this.

Does this happen on the latest release?

6058aa27-6ced-4d77-952a-bf55d59351c2 commented 2 months ago

I am on a pixel 7 and I do not see this.

Does this happen on the latest release?

I tested on the latest nightly build. Are you on the Android 15 beta?

harshad1 commented 2 months ago

I'm not on the android beta program, no

6058aa27-6ced-4d77-952a-bf55d59351c2 commented 2 months ago

I just had the same issue in Syncthing-Fork! I think this is probably caused by Android 15 then. Any idea what specifically causes this or how to fix it (or if it's a bug that needs to be reported to AOSP)?

gsantner commented 2 months ago

Maybe appcompat is not properly fully compatible yet

mendhak commented 6 days ago

I've just been upgraded to Android 15 and I can see this same problem.

I think this might be related to the edge to edge feature. If your app targets SDK 35, then the app spans the entire length of the screen.

chengnan049 commented 5 days ago

Pixel 6 same

ryrona2 commented 4 days ago

Easy fix would be to change target SDK to 34 instead, and rebuild and release. Since all stock Google Pixel owners are being force upgraded to Android 15 since two days ago, and all GrapheneOS users will be done the same in two days, this issue starts affecting many now. Buttons to save and revert last change and so on are basically unclickable as it is now.

Problem likely introduced here:

https://github.com/gsantner/markor/commit/5de71d5e562e3b5289c08f88c074e8ce4761fad8#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R17

Proper solution is to implement proper handling of edge to edge. But other projects that have done that have had to do quite a few code changes and later fixups, so I suggest reverting to SDK 34 first, get that update out, and then try to calmly retarget the code for SDK 35 after that including all needed code changes.

gsantner commented 4 days ago

I would prefer it to be fixed instead of downgrading. Anyway Google will enforce upgrade to 35 in upcoming times.