search

gsbDBI / torch-choice

Choice modeling with PyTorch: logit model and nested logit model
MIT License
39 stars 8 forks source link

Summary Statistics Helper Function for `ChoiceDataset` Class #7

Closed TianyuDu closed 2 years ago

TianyuDu commented 2 years ago

I am currently working on this on the dataset-summary-method branch here.

TianyuDu commented 2 years ago

I have created a pull request here implementing the summary() feature.

Here is an example output from the summary() method:

image

@kanodiaayush Could you please review the pull request a bit and let me know if you have any comments? I will merge the branch after the weekend.

kanodiaayush commented 2 years ago

I like this. I imagine after some people (or we ourselves) use it a bit we will have feedback points on this. I am approving the pull request. I took a look at the code and it looks good to me.

Thanks for adding this. This is a good one.

TianyuDu commented 2 years ago

Merged.