gsoft-inc / sg-orbit

The design system for ShareGate web apps.
https://orbit.sharegate.design
Apache License 2.0
102 stars 37 forks source link

link orbit and components together so their version is synced #1189

Closed alexasselin008 closed 1 year ago

alexasselin008 commented 1 year ago

Summary

At the moment, when modifying the components project, the bundle is incremented using a patch version, instead of following the same "bump severity".

With our current setup, the bundle basically ships the components project + ~10 lines of css from the @orbit-ui/css projects. I believe one day that we might move away from having a bundle package.

Until then, I'll link the versions of the 2 packages so every time the components packages gets updated, the bundle receives the same update. The only possible side effect i see is that if we ever modify one of the 10 lines of css from the @orbit-ui/css and the components are unaffected by the changes, we'll still bump the @orbit-ui/components packages. This is something i'm ok with.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 3a427bdd105cd861b45bf524de52d81424602b30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for sg-orbit ready!

Name Link
Latest commit 3a427bdd105cd861b45bf524de52d81424602b30
Latest deploy log https://app.netlify.com/sites/sg-orbit/deploys/640b4e514dfdbe000808e1d9
Deploy Preview https://deploy-preview-1189--sg-orbit.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for sg-storybook ready!

Name Link
Latest commit 3a427bdd105cd861b45bf524de52d81424602b30
Latest deploy log https://app.netlify.com/sites/sg-storybook/deploys/640b4e51b7605b0008961c0e
Deploy Preview https://deploy-preview-1189--sg-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.