Bundles - Githubissues

paulyoung commented 9 years ago

[x] Move .coffee files out of dist/ and into bundles/, leaving only .js files for distribution
[x] Update Gruntfile to build new distribution combos
[x] Remove duplication from Gruntfile and build files dynamically
[x] Fix/add clean tasks to Gruntfile
[x] Fix task dependencies in Gruntfile
[x] Update spec runner to use new distribution file
[x] Remove old .js files from dist/
[x] Ignore files in dist/
[x] Fix fatal error in Engine when running tests

Fixing the Grunt tasks is an important one - the build task wasn't even building the src files, so the tests weren't testing the latest code :scream_cat:

Now, these files will be created:

dist/gss.document.js
dist/gss.document.min.js
dist/gss.document.parser.js
dist/gss.document.parser.min.js
dist/gss.engine.js
dist/gss.engine.min.js
dist/gss.engine.parser.js
dist/gss.engine.parser.min.js

If anyone is opposed to or has better ideas for the naming, let's discuss :speech_balloon:

paulyoung commented 9 years ago

Android is failing on SauceLabs.

Inviz commented 9 years ago

GSS files were not built on travis, indeed. They had to be built locally. Thanks for tweaking that.

Inviz commented 9 years ago

Platform: ,android,
Passed: true

looks good to me. Great stuff

paulyoung commented 9 years ago

Merge?

Inviz commented 9 years ago

Sure. So the plan is to have master be the current branch, and be tagged for releases. No need for like a development branch or 2.1.x as I did it? I'll follow your recommendation, as I dont have strong opinion here.

paulyoung commented 9 years ago

Feature branches are good, especially for review. I rarely push to master directly.

I think a branch like 2.1-development is good for working toward a milestone with a defined scope/set of features. An open-ended release is never good.

Any patches/fixes can always go from a hotfix branch into master via pull request. At that point we might choose to tag master as 2.0.x as long as the changes are backwards-compatible under semantic versioning.

The 2.1-development branch should continually merge in upstream changes from master.

Making sure that master is always stable and deployable provides a reliable base for further development as well as giving us the freedom to tag release at a moment's notice.

endash commented 9 years ago

Just went to fix the undefined scripts bug in getWorkerUrl and saw that it was already done :+1:

gss / engine

Bundles #162