search

gtk-rs / sys

DEPRECATED, each crate has its own sys folder now.
http://gtk-rs.org/
MIT License
31 stars 25 forks source link

Use tempfile in tests #154

Closed EPashkin closed 4 years ago

EPashkin commented 4 years ago

Part of https://github.com/gtk-rs/gir/pull/870

cc @GuillaumeGomez, @sdroege

GuillaumeGomez commented 4 years ago

Thanks!

Merging once CI passed.

EPashkin commented 4 years ago

Build error seem related to https://github.com/gtk-rs/glib/pull/534

error: expected `*` or `+`

   --> /home/travis/.cargo/git/checkouts/glib-928cf7b282977403/5613e42/src/clone.rs:170:24

    |

170 |     ($($(@ $weak:ident)? $variables:ident),+ => $(@default-return $return_value:expr,)? move || $body:block ) => (

    |                        ^

    |

    = note: `?` is not a macro repetition operator in the 2015 edition, but is accepted in the 2018 edition
GuillaumeGomez commented 4 years ago

I think it might be bound to the rust version. But in any case, I realized we didn't update the rust version in the tests so I opened #155

EPashkin commented 4 years ago

Restarted failed jobs

EPashkin commented 4 years ago

Oops, forgot to update gtk4 etc.

GuillaumeGomez commented 4 years ago

Oh indeed. Good luck updating them. ;)

EPashkin commented 4 years ago

Done

EPashkin commented 4 years ago

CI passed too

GuillaumeGomez commented 4 years ago

Thanks!