search

gtm-nayan / svelte-pdfjs

https://gtm-nayan.github.io/svelte-pdfjs
MIT License
31 stars 8 forks source link

Upgrade dependencies #9

Closed Immortalin closed 2 years ago

Immortalin commented 2 years ago

Current dependencies contain a parsing bug, upgrading to node 16 fixed the issue.

netlify[bot] commented 2 years ago

✅ Deploy Preview for svelte-pdfjs ready!

🔨 Explore the source changes: 34e8484e3b0ed42c4b241ce7ace87e077dc4b892

🔍 Inspect the deploy log: https://app.netlify.com/sites/svelte-pdfjs/deploys/623956740ec04c0008c7ea49

😎 Browse the preview: https://deploy-preview-9--svelte-pdfjs.netlify.app

Immortalin commented 2 years ago

This is strange, the parsing bug is gone with node 16 on my local machine, but netlify still has it.

gtm-nayan commented 2 years ago

Not completely sure, but I think it's because Netlify is using node 16 to build but AWS (node 14) to run the render itself, if so I can't think of any way to fix this without https://github.com/aws/aws-lambda-base-images/issues/14 getting dealt with.

The engines field might be a nice addition regardless so at least the adapter-node users know what's going wrong if they're on an older version. Thanks.