search

gtxaspec / wz_mini_hacks

wz camera mods... make your camera better.
1.33k stars 114 forks source link

feature request: webserver: don't modify anything in /configs. #551

Closed gtxaspec closed 1 year ago

gtxaspec commented 1 year ago

@virmaior

I believe that allowing users to edit the configurations could introduce significant risks. If the configuration were to become corrupted or lost, it seems that the only recourse would be to restore from an unmodified backup of the configurations. In the worst-case scenario where a user doesn't have these backups, the camera could be permanently disconnected from the cloud due to the loss of the encryption keys. Perhaps we should disable this feature and have it be "read-only"...

What are your thoughts on this potential issue?

virmaior commented 1 year ago

very strongly agree. I actually did lose the config file on one of my V3s irrecoverably (not sure if it was from this code or something else I was trying).

I think basically read-only should be the default. I'm not even sure if it makes sense to allow any edits at all. Too much of a risk on that front.

I'll do this and the RTSP link for V2s soon... Juggling lots of other things right now!

virmaior commented 1 year ago

resolved in https://github.com/gtxaspec/wz_mini_hacks/pull/558

gtxaspec commented 1 year ago

updated in master.