guardian / grid

The Guardian’s image management system
https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service
Apache License 2.0
1.44k stars 121 forks source link

Add new metadata field for imageType, and UI controls #4334

Closed andrew-nowak closed 1 month ago

andrew-nowak commented 2 months ago

What does this change?

Adds a new metadata field named "image type" (or imageType in code responses), to designate an image as either "Photograph", "Illustration" or "Composite".

This has been requested by the Guardian's picture desk, so we can designate images into one of these categories and have that value pull through automatically into the content publishing tools.

image

Requires a mapping update (no migration necessary) -- see instructions at https://github.com/guardian/grid/tree/main/scripts#updatemapping

Values are set in config, by adding a key eg. imageTypes = ["Photograph", "Illustration", "Composite"]

Currently this value is only required by Kahuna, but I would recommend setting in common config, so that the values can be read by other services, in the case of future extensions of this feature.

How should a reviewer test this change?

Deploy to TEST, and try setting the value

How can success be measured?

Who should look at this?

Tested? Documented?

github-actions[bot] commented 2 months ago

Deploy build 12817 to TEST

All deployment options - [Deploy build 12817 to TEST](https://riffraff.gutools.co.uk/deployment/deployAgain?project=media-service%3A%3Agrid%3A%3Aall&build=12817&stage=TEST&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 12817 to TEST by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=media-service%3A%3Agrid%3A%3Aall&build=12817&stage=TEST&updateStrategy=MostlyHarmless)

From guardian/actions-riff-raff.

andrew-nowak commented 2 months ago

TODO:

prout-bot commented 1 month ago

Seen on usage (merged by @andrew-nowak 7 minutes and 38 seconds ago) Please check your changes!

prout-bot commented 1 month ago

Seen on auth, metadata-editor, thrall, collections, media-api (merged by @andrew-nowak 7 minutes and 43 seconds ago) Please check your changes!

prout-bot commented 1 month ago

Seen on cropper, kahuna (merged by @andrew-nowak 7 minutes and 46 seconds ago) Please check your changes!

prout-bot commented 1 month ago

Seen on leases (merged by @andrew-nowak 7 minutes and 55 seconds ago) Please check your changes!

prout-bot commented 1 month ago

Seen on image-loader (merged by @andrew-nowak 8 minutes and 41 seconds ago) Please check your changes!