expose aspect ratio and crop type on `asset-handle` elements (used by Pinboard)

guardian / grid

The Guardian’s image management system

https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service

Apache License 2.0

1.44k stars 121 forks source link

expose aspect ratio and crop type on `asset-handle` elements (used by Pinboard) #4350

Closed twrichards closed 1 month ago

twrichards commented 1 month ago

To help with https://github.com/guardian/pinboard/pull/312 and https://github.com/guardian/facia-tool/pull/1680 we want to know in pinboard what ratio/type the shared crops are. The Pinboard payload is already built from all the data attributes of the asset-handle (see #3190, #3704, #3705, #3683 & #3705 for context) so this PR just surfaces aspectRatio and cropType.

github-actions[bot] commented 1 month ago

Deploy build 12843 to TEST

All deployment options

- [Deploy build 12843 to TEST](https://riffraff.gutools.co.uk/deployment/deployAgain?project=media-service%3A%3Agrid%3A%3Aall&build=12843&stage=TEST&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 12843 to TEST by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=media-service%3A%3Agrid%3A%3Aall&build=12843&stage=TEST&updateStrategy=MostlyHarmless)

From guardian/actions-riff-raff.

prout-bot commented 1 month ago

Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @twrichards 22 minutes and 28 seconds ago) Please check your changes!