guardian / grid

The Guardian’s image management system
https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service
Apache License 2.0
1.44k stars 121 forks source link

Play 2.9 #4377

Open andrew-nowak opened 3 days ago

andrew-nowak commented 3 days ago

What does this change?

Perform upgrade to Play 2.9.

Ideally we want to be on Play 3.0, but that upgrade swaps Play's internals from using Akka to Pekko. We also have direct usages of Akka in our project, and while we could go to Play 3.0 and continue to run an Akka actor system to support those, it'd be nicest if we could swap both simultaneously. Stopping at 2.9 offers a nice stepping point where we can investigate that option, and also a spot to perform the Java 11 -> 17 upgrade too.

While testing locally I discovered that #4360 had quietly broken Thrall's ability to read the message queue while running locally, as the underlying Kinesis client attempts to connect with HTTP/2, but localstack only offers HTTP/1.1. Use some AWS SDK overrides to force it back onto HTTP/1.1 while running locally.

How should a reviewer test this change?

Run locally, deploy to TEST, try some usual Grid functionality.

How can success be measured?

Who should look at this?

Tested? Documented?

github-actions[bot] commented 3 days ago

Deploy build 12931 to TEST

All deployment options - [Deploy build 12931 to TEST](https://riffraff.gutools.co.uk/deployment/deployAgain?project=media-service%3A%3Agrid%3A%3Aall&build=12931&stage=TEST&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 12931 to TEST by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=media-service%3A%3Agrid%3A%3Aall&build=12931&stage=TEST&updateStrategy=MostlyHarmless)

From guardian/actions-riff-raff.