extra arguments to Range.setEndAfter()

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform

http://guardian.github.io/scribe/

Apache License 2.0

3.51k stars 245 forks source link

extra arguments to Range.setEndAfter() #472

Closed mindplay-dk closed 8 years ago

mindplay-dk commented 8 years ago

Search the codebase for .setEndAfter(), and you'll see Range.setEndAfter being called in a few places with what appears to be an extra 0 argument after the node?

According to Mozilla's DOM reference, that method takes one argument:

https://developer.mozilla.org/en-US/docs/Web/API/Range/setEndAfter

mindplay-dk commented 8 years ago

There are calls to Range.setStartAfter passing an extra second argument as well.

rrees commented 8 years ago

I'll check with @OliverJAsh in case of any undocumentated behaviour but it looks like the additional parameters could be removed

OliverJAsh commented 8 years ago

:+1: