search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.51k stars 245 forks source link

Undo misplaces the caret/cursor #478

Closed paperboyo closed 8 years ago

paperboyo commented 8 years ago

Hello,

Undo/Redo is not playing nice with the caret/cursor position (Undos/Redos at the end of a GIF, after placing an extra s):

undo scribe

I think Undo/Redo should leave the caret/cursor at the position it was before Undo/Redo was called for.

Regards Mateusz

rrees commented 8 years ago

This is due to our use of a time-based undo, effectively the whole local change is being undone, which is probably right in the majority of cases. Not sure what to do about it right now.

paperboyo commented 8 years ago

Thanks! Closing, if that’s what’s expected...