search

guardian / scribe

DEPRECATED: A rich text editor framework for the web platform
http://guardian.github.io/scribe/
Apache License 2.0
3.51k stars 245 forks source link

Fixes #448, #282; allow entering polish ż #480

Closed danburzo closed 8 years ago

danburzo commented 8 years ago

Now that I seem to be able to run Scribe locally, tests & all, I'm providing the fix I proposed on #448. I'm not sure how to approach writing a test for this, any ideas?

rrees commented 8 years ago

Thanks @danburzo. My best idea for testing this is to take the very complex test in the if and put it in its own testable function, perhaps called something like isRedoKeyCombination, and then write a test against that.

We don't have a module for this at the moment so maybe create a top-level module, something like keystrokes.js?

danburzo commented 8 years ago

Hi @rrees! I've just added a new keystrokes module and some tests.

rrees commented 8 years ago

Looks super good to me. :+1:

I'll try and organise a release as soon as I have time.