guberm / tortoisegit

Automatically exported from code.google.com/p/tortoisegit
0 stars 0 forks source link

Log Dialog: Selected item not remembered after refresh if item is one of the first 100 #1470

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
when I find the rev by input the revisions,then I select the rev.
but I clear the input in the edit box,the log window refresh,and the rev I just 
select is disselect.

I hope the selection rev can position there.

Original issue reported on code.google.com by nssb0000...@126.com on 17 Oct 2012 at 3:30

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Why is this patch necessary? Everytime when I click on a revision, it's saved 
and when if refresh the selection is remembered.

Original comment by sstrickr...@googlemail.com on 17 Oct 2012 at 5:43

GoogleCodeExporter commented 9 years ago
Currently, the log list does not always restore the selection. So I tested it.
However, EnsureVisible(), SetItemState(LVIS_SELECTED...), ... seemed do not 
work in this CLogListBase. For a simple CListCtrl, these methods can scroll to 
the selected row.

Original comment by ch3co...@gmail.com on 18 Oct 2012 at 2:34

GoogleCodeExporter commented 9 years ago
Hey!! It is reproducible.
If there are more than 100 commits, then it works (selection remains).
If there are 100 or less commits, then it does not work (selection disappear).

Original comment by ch3co...@gmail.com on 21 Oct 2012 at 12:37

GoogleCodeExporter commented 9 years ago

Original comment by sstrickr...@googlemail.com on 27 Oct 2012 at 4:05

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 0456479b7675.

Original comment by sstrickr...@googlemail.com on 27 Oct 2012 at 4:12

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Thanks, it works!

Original comment by ch3co...@gmail.com on 28 Oct 2012 at 3:17