minor additions to the scikit-gstat notebook

guiattard / geoscience-notebooks

Some notebook focusing on geoscientific applications.

14 stars 10 forks source link

minor additions to the scikit-gstat notebook #1

Closed mmaelicke closed 3 years ago

mmaelicke commented 3 years ago

Hey @guiattard , I made some minor text additions/corrections. I am not a hydrogeologist, so there is nothing I can add from a scientific point of view. I added some more plots, feel free to delete whatever you don't need. I also replaced most of the Variogram plots with the new plotly backend, producing some nice interactive plots. I also hope to publish a new version of scikit-gstat this week (0.3.7), which brings some more improvements. That will change the output of the describe function. I already ran the respective cell with the new output, so if you re-run the cell with scikit-gstat version <0.3.7, you will not be able to reproduce the output. But that will be fixed within the next few days. If you want to discuss something / request some more adaptions feel free to ask. I will have another time-slot available at the end of the week :)

Best

Mirko

guiattard commented 3 years ago

Hi Mirko,

Thank you very much for this PR. Your input is excellent, and I really like your plotly backend illustrations. I have only few questions :

do you have the possibility to modify the x-axis label of the not-normalized semi-variogram ? (the unit should be "m" and not "-",
do you confirm my comment saying that "with the current version of the scikit-gstat library, the variogram must be normalized to produce the array of errors" ?

Please add your name as co-author of this notebook (you can also add the URL you want to associate your GitHub profile...)

I will wait your second commit before merging.

Regards,

mmaelicke commented 3 years ago

Hey, I will address/implement your questions with the next commit later this week, Best Mirko

mmaelicke commented 3 years ago

I have not forgotten to continue here, I am just stuck in a huge pile of boring work right now. You will get another commit, either this weekend or on Mon/Tue.

Sorry, that you always have to wait for me...

guiattard commented 3 years ago

Don't worry... there is no rush. If you need one/Two more weeks it is not a problem for me.

guiattard commented 3 years ago

Dear Mirko,

Do you plan to make some adjustments or should I just merge your current PR ?

Regards,

mmaelicke commented 3 years ago

Sorry, I simply forgot about this PR. Give me another day, or merge anyway if there is nothing until tomorrow evening. Really sorry.