Closed guillep closed 4 years ago
And a completely commented out function in https://github.com/guilgautier/DPPy/blob/master/dppy/exotic_dpps_core.py
And another fully commented out function in https://github.com/guilgautier/DPPy/blob/master/dppy/random_matrices.py
I imagine fully commented out functions are some that are not yet working? maybe we can move them to a separate branch as experimental branches.
It seems there is some dead code commented, maybe it can be removed? (if needed it can always be recovered from git history)
# https://stackoverflow.com/questions/1854/python-what-os-am-i-running-on if _platform.startswith('linux'): # linux pass elif _platform == "darwin": # MAC OS X # https://markhneedham.com/blog/2018/05/04/python-runtime-error-osx-matplotlib-not-installed-as-framework-mac/ # import matplotlib # matplotlib.use('TkAgg') pass
Initially, I was also lauching Travis builds on MacOS and had hard time making sure things work see #6. Then, I set the backend to 'TkAgg', but sometimes figures were not displayed inline in Jupyter Notebooks Finally, I don't test on MacOS with Travis any more because
We can remove these lines, they make no sense
I imagine fully commented out functions are some that are not yet working? maybe we can move them to a separate branch as experimental branches.
They do work but are not used anymore, we can remove them.
It seems there is some dead code commented, maybe it can be removed? (if needed it can always be recovered from git history)