guilhemmarchand / TA-jira-service-desk-simple-addon

Atlasian JIRA add-on for Splunk alert actions
11 stars 9 forks source link

Problem setting Assets custom field object #181

Open brownschooldays opened 8 months ago

brownschooldays commented 8 months ago

We use the Splunk Jira Integration to create issues in our JSM from Splunk.

We have noticed that these are now failing where trying to set Assets field in the JSON for custom field setting. The following JSON has worked previously and matches the API documentation. This was working previously.

"customfield_12345": [{"key" : "TEST-123"}]

I am also successful when using this JSON to create/update an issue from POSTMAN.

Here is the error that is returned:

ERROR pid=4291 tid=MainThread file=cim_actions.py:message:292 | sendmodaction - signature="Failed to load jira_customfields="{"customfield_12345" : [ {"key" : "TEST-123"} ]"}" as a proper formated JSON object with exception="Expecting ',' delimiter: line 1 column 52 (char 51)""

spacepatcher commented 7 months ago

I have the same problem in my environment. The error says the JSON object is malformed and has one extra char " in the end (char 51). I found a bug in the code that adds this extra " if } is not the last character of the JSON string: https://github.com/guilhemmarchand/TA-jira-service-desk-simple-addon/blob/86ec16da98fe42df02d91bfc4e8ef127647f86cc/package/bin/ta_service_desk_simple_addon/modalert_jira_service_desk_helper.py#L1052

brownschooldays commented 7 months ago

Thanks for confirming @spacepatcher, I am using post function scripts to get around this; we pass the object key to a text field instead and then the script uses the key to set the Assets field as part of the create transition. Would be great to see this fixed though.

guilhemmarchand commented 7 months ago

Hi @spacepatcher @brownschooldays Thanks for sharing this, I am lacking a little bit of bandwdith nowadays but I will be reviewing this ASAP and will publish a new release with another few things pending!

brownschooldays commented 3 months ago

Hey @guilhemmarchand, Hope you are doing well! Do you know when you are expecting to do your next release including this fix? Thanks :)