search

guilhermerodz / input-otp

One time passcode Input. Accessible & unstyled.
https://input-otp.rodz.dev
MIT License
2.35k stars 47 forks source link

[BUG] Save in 1Password Button Overlaps Input #30

Closed jenewland1999 closed 5 months ago

jenewland1999 commented 5 months ago

Expected Behavior

Either the 1Password button save button is disabled or the CSS is adjusted to ensure it does not overlap the actual input's text

Current Behavior

The Save in 1Password Button overlaps the final digit in the OTP input obscuring the entered digit either partially or entirely.

Possible Solution

You can read a bit more about handling or disabling the 1Password integration in 1Password's docs

Steps to Reproduce

  1. Install 1Password Extension in your favourite browser of choice
  2. Visit a page where the OTPInput is being used (e.g. https://ui.shadcn.com/docs/components/input-otp or https://input-otp.rodz.dev/)
  3. Focus the input
  4. Ta-da! You now see the Save in 1Password Button overlapping the input 🎉

Context (Environment)

Detailed Description

n/a

Possible Implementation

n/a

jenewland1999 commented 5 months ago

Just seen that you made 8f4e92fa777dc7282fcfbe4b81dbbf632038fb31 a few hours ago so, I think my issue may already be redundant. That timing tho 😅

guilhermerodz commented 5 months ago

yep that's solved in the next release!

guilhermerodz commented 5 months ago

solved by 8f4e92f all the way until 5ee7e6e5d003b2d5a726dcfc1584934dc6ec5d69