search

guilhermesad / rspotify

A ruby wrapper for the Spotify Web API
MIT License
717 stars 290 forks source link

Change travis to github actions #254

Closed souzagab closed 2 years ago

souzagab commented 2 years ago

Hey @guilhermesad, first thanks for this project

I was browsing through the project and realized that it uses Travis, and test only the ruby-head version

So I thought it would be a good idea to test the older versions as well, and as I had some free time I proposed this change using GitHub Actions. I would like to hear your opinion if this improvement is a good choice

Also, when I was testing older versions of ruby, I realized that we don't support 2.1 and 2.0 versions any more because of the recent updates (you can check it here)

I would like to hear your opinion on that too (maybe drop the support for 2.0 and 2.1?), I would gladly work on this solution, if you think it makes sense.

guilhermesad commented 2 years ago

This looks great, thanks! Yes I think it's ok to drop support for 2.0 and 2.1. Since this replaces Travis, can you update the README to replace the Travis badge with a workflow status badge?

souzagab commented 2 years ago

This looks great, thanks! Yes I think it's ok to drop support for 2.0 and 2.1. Since this replaces Travis, can you update the README to replace the Travis badge with a workflow status badge?

Of course, I will do that

guilhermesad commented 2 years ago

looks great, thanks @souzagab!