The 'install' -target places some files in the installation root directory

guillaumeblanc / ozz-animation

Open source c++ skeletal animation library and toolset

http://guillaumeblanc.github.io/ozz-animation/

Other

2.46k stars 302 forks source link

The 'install' -target places some files in the installation root directory #161

Closed Peanhua closed 1 year ago

Peanhua commented 2 years ago

After issuing 'make install' the following files are incorrectly placed in the root of the installation directory:

CHANGES.md
LICENSE.md
README.md

The proper place for these files is probably something like "${CMAKE_INSTALL_PREFIX}/share/doc/ozz-animation/".

guillaumeblanc commented 2 years ago

Hi,

I submitted a change that shall fix it : 53d9d1a659cb0dab7fedd980dc5da6b4d04572e8. It's difficult for me to test it. Can you ?

Regards, Guillaume

Peanhua commented 2 years ago

Yes, works for me. Thanks =)

Tested with:

$ rm -rf /tmp/f; cmake -DCMAKE_INSTALL_PREFIX=/tmp/f .. && cmake --build ./ && make install
<snip>
$ ls /tmp/f /tmp/f/share/doc/ozz-animation/
/tmp/f:
bin  include  lib  share

/tmp/f/share/doc/ozz-animation/:
CHANGES.md  LICENSE.md  README.md

Not sure if I should be closing this issue or leave it up to you, so I'll opt the latter for now.