gumgum / gg-ez-vp

Simple video player with minimal setup, intuitive API and straightforward features
https://gumgum.github.io/gg-ez-vp
MIT License
7 stars 4 forks source link

Bugfix/inconsistent VAST loading #64

Closed edrpls closed 4 years ago

edrpls commented 4 years ago

This PR fixes VAST/VPAID inconsistent loading. I think this happened because we didn't replace the [timestamp] macro from the VAST URLs, and ad servers don't seem to like this.

After replacing the macro, this issue seems to be gone.

Additionally, for easier debugging, I improved the demo page so that sources can be changed dynamically now.

The player will now get the BaseURL from the last gg-ez-vp.js script it finds instead of throwing an error when there is more than one script, but this is just a temporary fix while #63 is fixed.

edrpls commented 4 years ago

Closes #60