Bugfix/vpaid rendering 3

gumgum / gg-ez-vp

Simple video player with minimal setup, intuitive API and straightforward features

https://gumgum.github.io/gg-ez-vp

MIT License

7 stars 4 forks source link

Bugfix/vpaid rendering 3 #72

Closed edrpls closed 4 years ago

edrpls commented 4 years ago

This PR will refactor VPAID loading to be able to use cached VPAID scripts, as they would not run from cache because of a race condition with the script.onload listener. This closes #60.

This broke VPAID replay, and I had to reopen #58.

edrpls commented 4 years ago

There's an issue with vpaid clickthrough on iOS, currently trying to fix that.

edrpls commented 4 years ago

Clickthrough on iOS has been fixed, but for some reason, opening VPAID in an iframe in Android Chrome is now broken.

edrpls commented 4 years ago

Rendering issues and clickthrough issues have been addressed, it was a mix of CSS problems that prevented clicking on the VPAID slot and using a new independent div as slot.

edrpls commented 4 years ago

This will also fix the issue from #70 on VPAID, but additional work is needed for VAST without VPAID.