search

gurnec / btcrecover

An open source Bitcoin wallet password and seed recovery tool designed for the case where you already know most of your password/seed, but need assistance in trying different possible combinations.
GNU General Public License v2.0
1.31k stars 699 forks source link

Crashes with P2SH address #221

Open migu0 opened 6 years ago

migu0 commented 6 years ago

Thanks so much for creating this tool.

I'm trying to recover my Ledger BIP 39 backup seed (I have all words written down but it doesn't validate). The first account created was a BTC account with a number in this format: 3P14159f73E4gFr7JterCCQh9QjiTjiZrG (starting with 3). When I enter this address, I get the following error:

An entered address is invalid (not a Bitcoin P2PKH address; version byte is 0x05)

I created this account about 10 days ago. I don't know too much about Bitcoin but I think it's a Segwit account and it's P2SH and not P2PKH. Can I make this somehow work? I also have an Ethereum and a Ripple account that I created after creating the Bitcoin account.

Thanks

migu0 commented 6 years ago

I just saw that there's an option to run the tool from the command line. Is there an option on the command line to run ./seedrecover.py with a P2SH generated BTC address?

sjnesbitt commented 6 years ago

migu0, could you provide me with the command line argument you used. I have looked in seedrecovery and not found the option you mention. thanks in advance. Did you recover your correct seed? I have my words written down also and when I put them back into my ledger nano s it states it is invalid. I checked for any spelling and possible miswritings using the BIP 39 txt words. To no avail.

migu0 commented 6 years ago

Sorry I can’t remember the command, I found it in one of the issues somewhere. Haven’t managed to recover anything, it looks like this tool could support non legacy BTC addresses soon: https://github.com/gurnec/btcrecover/issues/174

Were all of your words in the BIP 39 words list as well? I almost think this could be a Ledger bug (generating invalid seed phrases) as I triple checked everything when writing it down.

vly3 commented 6 years ago

I have the same problem. I also need to recover my Ledger BIP 39 seed, and I too get the message “An entered address is invalid (not a Bitcoin P2PKH address; version byte is 0x05)” when I put in my Bitcoin address, which is a Segwit address. I created the wallet on Jan 3rd.

sjnesbitt commented 6 years ago

I have not resolved this issue yet.   There are basic things you can try first.   Look for similar words like car to cart, etc.  If I resolve this I will post it.

Sent from Yahoo Mail on Android

On Tue, Feb 13, 2018 at 20:12, vly3notifications@github.com wrote:
I have the same problem. I also need to recover my Ledger BIP 39 seed, and I too get the message “An entered address is invalid (not a Bitcoin P2PKH address; version byte is 0x05)” when I put in my Bitcoin address, which is a Segwit address. I created the wallet on Jan 3rd.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

vly3 commented 6 years ago

My wallet also had a Ripple address, and I am certain that it was the first and only Ripple address generated from that seed. If I test against the Ripple address only one address will have to be generated. I don’t know if the Bitcoin Segwit address was the first, so I’d have to generate 5 addresses if I test against that.

sjnesbitt commented 6 years ago

I have recovered my bitcoins today.  I identified my paraphrase using a couple of programs I put together from others.  Let me know if I can help.

Sent from Yahoo Mail on Android

On Thu, Feb 15, 2018 at 10:11, vly3notifications@github.com wrote:
My wallet also had a Ripple address, and I am certain that it was the first and only Ripple address generated from that seed. If I test against the Ripple address only one address will have to be generated. I don’t know if the Bitcoin Segwit address was the first, so I’d have to generate 5 addresses if I test against that.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

vly3 commented 6 years ago

I have recovered my bitcoins today. I identified my paraphrase using a couple of programs I put together from others.

I am happy to hear good news. I hope I can be so lucky. What programs did you put together?

sjnesbitt commented 6 years ago

I am attempting to contribute to github now.  I will let you know when it is done.

Steve Seek ye first the kingdom of God... Matthew 6:33 

On Saturday, February 17, 2018, 5:07:29 AM UTC, vly3 <notifications@github.com> wrote:

I have recovered my bitcoins today. I identified my paraphrase using a couple of programs I put together from others.

I am happy to hear good news. I hope I can be so lucky. What programs did you put together?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

vly3 commented 6 years ago

I recovered my seed using a modified version of Ian Coleman’s Mnemonic Code Converter.

https://github.com/iancoleman/bip39

I modified his javascript to feed different mnemonics into the input field and then looked for a match to my ripple address.

vamp111 commented 6 years ago

when segwit please, my cold storage is Segwit adress and all my btc is there i lack 1 out of 12 mnemonic words...

vly3 commented 6 years ago

vamp111, my modification of Ian Coleman's Mnemonic Code Converter might work for you, but it is too messy for me to publish and I am not familiar with how to publish on github. If you email me at vly3 at yahoo dot com, I will send you a copy and tell you how to use it.

vamp111 commented 6 years ago

hi, i just did, please check MG05@ is my mail

vly3 commented 6 years ago

I just sent it.