change the bash script for installing wkhtmltopdf in ubuntu

gutschilla / elixir-pdf-generator

Create PDFs with wkhtmltopdf or puppeteer/chromium from Elixir.

MIT License

330 stars 71 forks source link

change the bash script for installing wkhtmltopdf in ubuntu #54

Closed cosmos-sajal closed 5 years ago

cosmos-sajal commented 5 years ago

What?

Changed the bash script for installation in ubuntu, as the current script was breaking

Why?

The current debian package is broken. (ref - https://askubuntu.com/questions/604029/dependency-problems-with-wkhtmltopdf-when-trying-to-install-latest-version)

cosmos-sajal commented 5 years ago

@gutschilla Can you please check?

gutschilla commented 5 years ago

@cosmos-sajal - Thanks a lot for reporting. Can you please elaborate in which way the old package is broken? Maybe we should report back to the Wkhtmltopdf team

gutschilla commented 5 years ago

Other than that I won't be able to check until Monday, sadly.

cosmos-sajal commented 5 years ago

@gutschilla Was getting the following error while trying the bash script in readme -

wkhtmltox depends on libpng16-16; however: Package libpng16-16 is not installed. wkhtmltox depends on libssl1.1; however: Package libssl1.1 is not installed.

It was a broken package issue from ubuntu itself. I checked online and arrived at the above solution.

Just didn't want anyone in wasting time and effort to get to the solution, and hence updated the README.

gutschilla commented 5 years ago

Ah, I see – you're running Ubuntu Xenial, the docs mention Ubuntu Bionic. I'll add a second line to cover this. Changing the download URL to Xenial will break the docs for them. The docs will be updated in v0.5.5,

Thanks a lot for reporting the issue!

gutschilla commented 5 years ago

I will not merge this as this would force anyone to be on Ubuntu 16. I clarified (./README) on how to obtain the correct .deb file